Copy aspect files to workspace

[LeFrosch]

Copy all aspects into the workspace instead of using a --override_repository or --inject_repository flag to point to the bundled aspects. This provides some benefits:

• No more caching problems caused by --override_repository
• No different logic for Bazel 8, since --inject_repository is also not required

Since aspects need to be copied to the workspace anyway, we can now store them inside the plugin jar. This makes accessing the aspects easier, since they are not in different locations for tests and production.

Also adds aspect writing as a dedicated sync step:

[mai93]

Thanks @LeFrosch! I left some comments. I am not familiar with the template related parts if you would like someone else to review those.

[LeFrosch]

rebased master

[srdo-humio]

@LeFrosch I think there might be a small bug somewhere in this.

In our internal repo, this ends up passing --aspects=//.ijwb/aspects:intellij_info_bundled.bzl%intellij_info_aspect to bazel build on sync, which is not a legal label, since it's missing the : after the two slashes.

[LeFrosch]

@srdo-humio Thanks for reporting this, but as far as I understand this should be legal label since in the .ijwb/aspects directory should be a BUILD file and therefore .ijwb/aspects is the package and intellij_info_bundled.bzl the target. Please correct me if I am wrong.

[srdo-humio]

@LeFrosch Bazel 7.4.1 at least seems to not like it. I'm getting this in the console:

ERROR: Label '//.ijwb/aspects:intellij_info_bundled.bzl' is invalid because '.ijwb/aspects' is not a package; perhaps you meant to put the colon here: '//:.ijwb/aspects/intellij_info_bundled.bzl'?

which then causes the sync to fail entirely

Here's what's in the directory, just to rule out issues with that:

BUILD.bazel                    intellij_info_impl_bundled.bzl
artifacts.bzl                  java_classpath.bzl
code_generator_info.bzl        java_info.bzl
fast_build_info_bundled.bzl    make_variables.bzl
flag_hack.bzl                  python_info.bzl
intellij_info.bzl              tools
intellij_info_bundled.bzl

But you're right, the target syntax appears correct.

Edit:

And I checked, it is definitely the --aspects=//.ijwb/aspects:intellij_info_bundled.bzl%intellij_info_aspect flag that causes the failure, building without it works fine.

[srdo-humio]

Sorry, I see the problem. We had .ijwb in our .bazelignore. Removing it from there fixes the issue. Thanks for responding.

[LeFrosch]

Ah perfect, thanks for reporting this anyway. Might be good to know in future.