Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip flags for coverage support with remote execution #24927

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Flip flags for coverage support with remote execution #24927

wants to merge 1 commit into from
+5 −42

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jan 15, 2025 •
edited
Loading

With BwoB enabled by default, these flags are already relevant with a disk cache. They are not easily discovered and make for a bad onboarding experience for coverage.

Also remove the outdated "RE caveats" section from the coverage docs as all issues have been resolved.

RELNOTES: --experimental_split_coverage_postprocessing and --experimental_fetch_all_coverage_outputs are now enabled by default.

@fmeum
Flip flags for coverage support with remote execution
c3bc9ef 
With BwoB enabled by default, these flags are already required with a disk cache. They are not easily discovered and make for a bad onboarding experience for coverage.

Also remove the outdated "RE caveats" section from the coverage docs as all issues have been resolved.

RELNOTES: `--experimental_split_coverage_postprocessing` and `--experimental_fetch_all_coverage_outputs` are now enabled by default.
@fmeum fmeum force-pushed the flip-coverage-flags branch from b685f35 to c3bc9ef Compare January 15, 2025 17:01
@fmeum fmeum marked this pull request as ready for review January 15, 2025 17:09
@fmeum fmeum requested review from a team, gregestren and fweikert as code owners January 15, 2025 17:09
@fmeum fmeum requested a review from c-mita January 15, 2025 17:10
@github-actions github-actions bot added team-Configurability platforms, toolchains, cquery, select(), config transitions team-Remote-Exec Issues and PRs for the Execution (Remote) team team-Documentation Documentation improvements that cannot be directly linked to other team labels awaiting-review PR is awaiting review from an assigned reviewer labels Jan 15, 2025
@fmeum fmeum removed request for a team, gregestren and fweikert January 15, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-mita c-mita Awaiting requested review from c-mita

Assignees
No one assigned
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Configurability platforms, toolchains, cquery, select(), config transitions team-Documentation Documentation improvements that cannot be directly linked to other team labels team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fmeum