feat: data and pyi files in the venv #2936
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the necessary `.dist-info` files into the mix and should get us reasonably close to handling 99% of the cases. The expected differences from this and a `venv` built by `uv` would be: * Shared libraries are stored in `<package>.libs` in `uv` venvs. This can be achieved in `rules_python` by changing the `installer` settings in the `wheel_installer/wheel.py#unzip` function. * The `RECORD` files are excluded from the `venv`s for better cache hit rate in `bazel`, however I am not sure if we should do that for actual wheels that are downloaded from the internet. Tested: - [x] Building the `//docs` and manually checking the symlinks. - [ ] Unit tests Work towards bazel-contrib#2156
|
I am thinking I should also link other things passed as I think excluding anything outside |
aignas
changed the title
aignas
changed the title
|
I'll push some of the changes later but I have a hard time writing a test that would fullfill some of the requirements in the PR todo list. |
aignas
commented
May 30, 2025
| else: | ||
| kind_map[entry.venv_path] = entry.link_to_path | ||
|
|
||
| # We overwrite duplicates by design. The dependency closer to the |
There was a problem hiding this comment.
FYI, needed to invert the logic here to make it work with the test I had, maybe my test is wrong?
aignas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the necessary
.dist-infofiles into the mixand should get us reasonably close to handling 99% of the cases.
The expected differences from this and a
venvbuilt byuvwould be:<package>.libsinuvvenvs. It seemsthat this happens if you install latest package versions (e.g. numpy) has
libraries in
numpy.libsin the latest version.RECORDfiles are excluded from thevenvs for better cache hitrate in
bazel, however I am not sure if we should do that for actualwheels that are downloaded from the internet.
Tested:
//docsand manually checking the symlinks..pyifiles get included..dist_infogets included.Work towards #2156