feat(uv): handle credential helpers and .netrc #2872
+63
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows one to download the uv binaries from private mirrors. Work towards bazel-contrib#1975.
|
Marking as draft because of what I've found during testing. This may need some extra polishing before it is ready. |
|
Decided to mark as ready for review since solving the |
rickeylev
requested changes
May 27, 2025
| @@ -27,6 +27,11 @@ BEGIN_UNRELEASED_TEMPLATE | |||
| ## Unreleased | |||
| [0.0.0]: https://github.com/bazel-contrib/rules_python/releases/tag/0.0.0 | |||
| and the sha256 values | |||
There was a problem hiding this comment.
Bad merge or copy/paste?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows one to download the uv binaries from private mirrors.
The plumbing of the auth attrs allows us to correctly use the
~/.netrcor the credential helper for downloading from mirrors that require
authentication.
Testing notes:
with private mirrors, but I think it is fine for users in such cases
to define the
uvsrcs using theurlsattribute.Work towards #1975.