Skip to content

bzlmod: allow custom node_repositories definitions #3802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

bzlmod: allow custom node_repositories definitions #3802

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions nodejs/extensions.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
"extensions for bzlmod"

load("//nodejs/private:node_versions.bzl", "NODE_VERSIONS")
load(
":repositories.bzl",
"DEFAULT_NODE_REPOSITORY",
Expand Down Expand Up @@ -47,6 +48,7 @@ def _toolchain_extension(module_ctx):
nodejs_register_toolchains(
name = k,
node_version = v.node_version,
node_repositories = v.node_versions,
node_version_from_nvmrc = v.node_version_from_nvmrc,
node_urls = v.node_urls,
include_headers = v.include_headers,
Expand All @@ -62,6 +64,10 @@ _ATTRS = {
doc = "Version of the Node.js interpreter",
default = DEFAULT_NODE_VERSION,
),
"node_versions": attr.string_list_dict(
doc = "Overrides to the default list of Node.js versions to download.",
default = NODE_VERSIONS,
),
"node_version_from_nvmrc": attr.label(
allow_single_file = True,
doc = """The .nvmrc file containing the version of Node.js to use.
Expand Down