Skip to content

resolve issue 319, handling test method name for Parameterized tests #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

asbeane
Copy link

@asbeane asbeane commented Mar 21, 2025

Attempts to resolve #319

checks for the ordinal (in parameterized tests), and this case maps each test case to the method name and wraps each of these in their own test suite so the tests show up with each parameterized test as test case, and the method has a test suite.

Basically the hierarchy (for parameterized tests)

Test Class (also a test suiteA)
Test case/method
[1] params=...
[2] params=....

Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. This seems okay, but I've a couple of questions:

  1. How does Gradle and/or Maven report this in their log files? We should be compatible with that, since those are widely used tools, and the XML files are sucked into CI runners to display results.
  2. Can we please have a test for this? Without one, we're likely to regress this output as we continue to work in this area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BazelJUnitOutputListener doesn't log methodName for @ParameterizedTest
2 participants