Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin support to Spotbugs #233

Merged

Conversation

mwindmark
Copy link
Contributor

Adds support for using plugins with SpotBugs, see documentation for common plugins.

This can for example be used to activate the Find Security Bugs plugin.

spotbugs_config(
    name = "spotbugs-custom-config",
    effort = "default",
    fail_on_warning = True,
    plugin_list = [
        "@maven//:com_h3xstream_findsecbugs_findsecbugs_plugin",
    ],
    visibility = ["//visibility:public"],
)

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for the contribution! Would you be able to add an example or test which uses this new functionality?

@mwindmark
Copy link
Contributor Author

This looks good, thanks for the contribution! Would you be able to add an example or test which uses this new functionality?

Thanks! I saw that you recently added the example tests_and_lints so I extended that with Spotbugs. See the changes in 6c6a3cc

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks so much!

@illicitonion illicitonion merged commit 284258f into bazel-contrib:main Jan 12, 2024
2 checks passed
@mwindmark mwindmark deleted the mwindmark/spotbugs-plugin-support branch January 12, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants