Skip to content

feat(diff_test): adding a hermetic toolchain #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

manuelnaranjo
Copy link

@manuelnaranjo manuelnaranjo commented Mar 6, 2025

Trying to add a diff hermetic toolchain based on
https://github.com/uutils/diffutils

Closes: #529

@manuelnaranjo manuelnaranjo changed the title diff_test: adding a hermetic toolchain feat(diff_test): adding a hermetic toolchain Mar 6, 2025
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

What's left to do here? Why is it only a Draft?

@manuelnaranjo
Copy link
Author

I didn't fully test if IIRC, I think it lacks -r which would need to be implemented on starlark/shell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: Allow diff_test to specify diff toolchain
2 participants