-
-
Notifications
You must be signed in to change notification settings - Fork 101
[Bug]: Yq target does not work with external builds #548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I can't reproduce, I'm trying this in an external workspace in this repo:
and it succeeds. |
fwiw the target i was hitting this with initally was the envoy docs - which i then debugged and added proposed fix - so pretty certain diagnosis/etc. Are you sure its seeing the target/s as external testing in this way ? |
Sorry, I don't mean to say there isn't a bug, I just need some help to reproduce it so I can add a test case for it and verify a fix, if it's not identical to your PR (accounting for |
if i get some time tomorrow ill try and setup a minimal reproducer |
upstream issue is bazel-contrib/bazel-lib#548 pr is: bazel-contrib/bazel-lib#547 Currently the websites and archive patch this indepenendently This caused a breakage (in all 3) when aspect lib was updated envoyproxy/envoy-website#368 This should prevent that until there is some upstream resolution Signed-off-by: Ryan Northey <[email protected]>
bazel/patch: Patch aspect lib to resolve external build issue upstream issue is bazel-contrib/bazel-lib#548 pr is: bazel-contrib/bazel-lib#547 Currently the websites and archive patch this indepenendently This caused a breakage (in all 3) when aspect lib was updated envoyproxy/envoy-website#368 This should prevent that until there is some upstream resolution Signed-off-by: Ryan Northey <[email protected]>
What happened?
Cryptic message about non-existing file paths
Version
Development (host) and target OS/architectures: linux/debian
Output of
bazel --version
:Version of the Aspect rules, or other relevant rules from your
WORKSPACE
orMODULE.bazel
file:Language(s) and/or frameworks involved:
How to reproduce
Any other information?
I proposed a fix in #547 - seems that may not work in all situations, but at least fixes this problem
The text was updated successfully, but these errors were encountered: