Skip to content

[Bug]: Yq target does not work with external builds #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phlax opened this issue Sep 25, 2023 · 4 comments
Open

[Bug]: Yq target does not work with external builds #548

phlax opened this issue Sep 25, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@phlax
Copy link

phlax commented Sep 25, 2023

What happened?

Cryptic message about non-existing file paths

Version

Development (host) and target OS/architectures: linux/debian

Output of bazel --version:

bazel 6.3.2

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file:

1.34.1

Language(s) and/or frameworks involved:

How to reproduce

Add a yq target, try to build from an external workspace

Any other information?

I proposed a fix in #547 - seems that may not work in all situations, but at least fixes this problem

@phlax phlax added the bug Something isn't working label Sep 25, 2023
@alexeagle alexeagle self-assigned this Oct 5, 2023
@alexeagle
Copy link
Collaborator

I can't reproduce, I'm trying this in an external workspace in this repo:

cd e2e/smoke
bazel build @aspect_bazel_lib//lib/tests/yq:all

and it succeeds.

@phlax
Copy link
Author

phlax commented Oct 5, 2023

fwiw the target i was hitting this with initally was the envoy docs - which i then debugged and added proposed fix - so pretty certain diagnosis/etc. Are you sure its seeing the target/s as external testing in this way ?

@alexeagle
Copy link
Collaborator

Sorry, I don't mean to say there isn't a bug, I just need some help to reproduce it so I can add a test case for it and verify a fix, if it's not identical to your PR (accounting for --nolegacy_external_runfiles case)

@phlax
Copy link
Author

phlax commented Oct 5, 2023

if i get some time tomorrow ill try and setup a minimal reproducer

phlax added a commit to phlax/envoy that referenced this issue Oct 24, 2023
upstream issue is bazel-contrib/bazel-lib#548
pr is: bazel-contrib/bazel-lib#547

Currently the websites and archive patch this indepenendently

This caused a breakage (in all 3) when aspect lib was updated

envoyproxy/envoy-website#368

This should prevent that until there is some upstream resolution

Signed-off-by: Ryan Northey <[email protected]>
phlax added a commit to envoyproxy/envoy that referenced this issue Oct 24, 2023
bazel/patch: Patch aspect lib to resolve external build issue

upstream issue is bazel-contrib/bazel-lib#548
pr is: bazel-contrib/bazel-lib#547

Currently the websites and archive patch this indepenendently

This caused a breakage (in all 3) when aspect lib was updated

envoyproxy/envoy-website#368

This should prevent that until there is some upstream resolution

Signed-off-by: Ryan Northey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants