Python Hierarchy Implementation #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…subscript in vector/list conversions
mberaha
reviewed
Jul 2, 2022
|
The Running after a Also, it would be nice to have a notebook comparing the C++ implementation of the NNIG/laplace hierarchies with the Python ones, to make sure that the code is correct (same density estimate) and show the performance loss |
|
We've updated the README (we tried to install from 0 on a virtual machine following the updated README, so we are sure it works), please try again. |
mberaha
reviewed
Jul 4, 2022
docs/examples/README.md
Outdated
| 1) Clone the repository | ||
| ```shell | ||
| git clone --recurse-submodule [email protected]:bayesmix-dev/pybmix.git | ||
|
|
There was a problem hiding this comment.
the installation should be part of the main Readme
I still get the same exact error. Removing the last |
Do you think this is OS dependent error? Because it works fine for us, also on VM's, but we're all using Linux. |
Seems its working without that also for us. We check better and update it. |
|
Also, installation is not clear for me at the moment. E.g., and then running |
Were you inside the repository directory when that error occurred? |
In the end it did not work. |
To run the notebook we included the lines before importing anything in the pybmix folder. We did not push this since it is not present in the other notebooks and when the pip install command will work it will not be needed anymore. Should we add it? (And in case should we add it also to the other notebooks?) |
I'm at the root folder of the first line of the output comes from |
But when |
This is the full output when calling It seems that SCRIPT_DIR = /Users/marioberaha/dev/tests/pybmix/.. |
Does it work if instead we define SCRIPT_DIR as ? It works for me |
|
yes works for me as well |
mberaha
approved these changes
Jul 6, 2022
There was a problem hiding this comment.
I've had a quick look at the C++ code. I have not followed the development closely, so this is just an external check for major mishaps. Everything looks fine, I have only noted a small amount of observations.
Also, one last thing: what's up with the empty file pybmix/core/pybmixcpp/tmp.hpp?
|
If everything has been addressed, you can merge the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
In this PR we present the implementation of the python hierarchy.
Note that, the states and hypers now are stored in std::vectors for the sake of generalization; there is an internal 'switcher' implemented for the user to change between different hierarchy implementations in python dynamically (in runtime).
*The documentation and styling of the code are not yet done.
We would like to mention that we did try using the 'make opaque' technique to pass by reference between c++ and python, but that surprisingly didn't improve the performance.
To build the library:
To run an example using the python implementations:
$ python3 docs/examples/test_run.pyWe would like to hear your comments to improve the code.