basho-otp-18 compatibility #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you also send this PR to https://github.com/Feuerlabs/exometer_core ? |
|
The part of the patch that makes it build correctly in OTP 18 (the update to using parse_trans 2.9.2 instead of 2.9) is already part of exometer_core 1.4. Eliminating the "Deprecated BIF" warning would also be nice, but is not nearly as high priority. I'll be investigating soon whether it makes more sense to update the Basho fork to 1.4 or to just add this patch. |
|
Ah, sorry. I should of course have detected (or known) that myself. :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make exometer_core work in OTP 18.
Update to parse_trans version 2.9.2 to get a version of edown that has been fixed for the removal in OTP 18.0 of the edoc doclet_gen.packages and doclet_gen.filemap record fields.
Change erlang:now() to os:timestamp(), to eliminate the "Deprecated BIF" warning in OTP 18.0.
The modified exometer_core application passes "make test" in basho/otp branches basho-otp-16, basho-otp-17, and basho-otp-18. "TEST COMPLETE, 19 ok, 0 failed of 19 test cases"