Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close cycled async http clients properly. Related BT-13951 #1439

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marius-baseten
Copy link
Contributor

🚀 What

💻 How

🔬 Testing

@marius-baseten marius-baseten requested review from squidarth, htrivedi99 and parallelipopat and removed request for htrivedi99 March 8, 2025 01:38
@marius-baseten marius-baseten changed the title WIP Close cycled async http clients properly. Related BT-13951 Mar 8, 2025
Copy link

linear bot commented Mar 8, 2025

Copy link
Collaborator

@squidarth squidarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! So the theory here is if there are two requests in parallel, one of them could cause client to cycle out, which will then get garbage collected before the other request finishes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants