Support custom image with race detector. Race condition fix.#2
Open
willosa wants to merge 2 commits intorelease-23.9from
Open
Support custom image with race detector. Race condition fix.#2willosa wants to merge 2 commits intorelease-23.9from
willosa wants to merge 2 commits intorelease-23.9from
Conversation
…d new image based on official image base. Add fix for add scheme race condition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix race condition with AddToSchema in ClusterPolicyController.init()
See issue: NVIDIA#689 (comment)
The write side stack trace from race detector:
WARNING: DATA RACE Write at 0x00c0000eb3b0 by goroutine 194: runtime.mapassign() /usr/local/go/src/runtime/map.go:579 +0x0 k8s.io/apimachinery/pkg/runtime.(*Scheme).AddKnownTypeWithName() /vendor/k8s.io/apimachinery/pkg/runtime/scheme.go:174 +0x357 k8s.io/apimachinery/pkg/runtime.(*Scheme).AddKnownTypes() /vendor/k8s.io/apimachinery/pkg/runtime/scheme.go:148 +0x205 github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring/v1.addKnownTypes() /vendor/github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring/v1/register.go:49 +0x7fe k8s.io/apimachinery/pkg/runtime.(*SchemeBuilder).AddToScheme() /vendor/k8s.io/apimachinery/pkg/runtime/scheme_builder.go:29 +0xa1 k8s.io/apimachinery/pkg/runtime.(*SchemeBuilder).AddToScheme-fm() <autogenerated>:1 +0x1f github.com/NVIDIA/gpu-operator/controllers.(*ClusterPolicyController).init() /controllers/state_manager.go:786 +0x663 github.com/NVIDIA/gpu-operator/controllers.(*ClusterPolicyReconciler).Reconcile() /controllers/clusterpolicy_controller.go:128 +0x6cb