Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PauseController.getWaitState() uses time.After() to create a timeout channel for paused requests.
Per the Go documentation, the underlying time.Timer created by time.After is not garbage collected until it fires.
When a paused service resumes (or is stopped) before the FailAfter duration expires, the timer becomes orphaned — still held by the Go runtime but serving no purpose.
Under high request volume with a long FailAfter duration, each incoming request allocates a new orphaned timer, causing unbounded memory growth proportional to request_rate × FailAfter_duration.
Fix
Replace time.After with time.NewTimer, which returns a *time.Timer that can be explicitly stopped.