feat: new erc20 transfer tests #161
Conversation
🟡 Heimdall Review Status
|
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn test_basic_eth_call_with_flashblocks() -> eyre::Result<()> { |
There was a problem hiding this comment.
this test is ~the same as already existing in rpc.rs. Don't think it needs to exist in erc20.rs
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn test_erc20_balance_progression() -> eyre::Result<()> { |
There was a problem hiding this comment.
all of these steps appear to be covered in the multi user balances test as well.
im not sure what the SimpleToken contract is that you used, but it may be more interesting here to track balance changes across functions other than just transfer here to ensure correctness rather than this test which seems like a subset of test_multi_user_balances
Specifically, if a mint function is available - we should be able to track that. If a burn function is available, we should track that. And transferFrom (i.e. approve + transferFrom) would be great.
|
Review Error for haardikk21 @ 2025-11-03 16:05:00 UTC |
3 participants
Partly covers #151; new test environment from #160
I had to copy some code to new test env (
flashblocks-rpc/tests).Needs to be added to close #151 completely: