Svelte Package - Migrate to Svelte 5 Runes#160
Open
kabaww wants to merge 3 commits intobarvian:mainfrom
Open
Conversation
|
@kabaww is attempting to deploy a commit to the Barvian Team on Vercel. A member of the Team first needs to authorize it. |
kabaww
commented
Oct 19, 2025
| set __svelte_batched(batched: boolean) { | ||
| this.batched = batched | ||
| } | ||
| override set data(data: Data | undefined) { |
Author
There was a problem hiding this comment.
I am not too sure about this omission of the override keyword. I know it's optional, but the updated vite-plugin-svelte throws a fit when this keyword is set.
I think this is because of the naming conflict of NumberFlowLite
kabaww
commented
Oct 19, 2025
| const group = getGroupContext() | ||
| group?.register?.(elStore) | ||
|
|
||
| $effect(() => { |
Author
There was a problem hiding this comment.
I am not completely sure if this is the correct way to update the writable when el updates.
I think we need to use writable.set()
|
❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#138
WARNING: This is a breaking change for the
@number-flow/sveltepackage and it will make the package incompatible for those still in Svelte 4.Svelte has deprecated a lot of methods used in the svelte package such as
afterUpdate,beforeUpdate.This PR will enable Svelte 5 users to make use of number-flow with Runes enabled.
I have not checked if there is a solution for backwards compatibility with Svelte 4, but I don't think it's possible.