Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation on macOS #2

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Fix compilation on macOS #2

merged 1 commit into from
Jan 9, 2025

Conversation

fabian-lunarg
Copy link

  • add required 'override' statements
  • tested on macOS14.5, clang-1500.3.9.4

@fabian-lunarg
Copy link
Author

fabian-lunarg commented Sep 9, 2024 •
edited
Loading

@bartosz-muszarski-arm:
this addresses a macOS compilation-issue in your related PR

@fabian-lunarg
Fix compilation on macOS
725f3b7 
- add required 'override' statements
- tested on macOS14.5, clang-1500.3.9.4
@fabian-lunarg fabian-lunarg force-pushed the fabian_fix_vulkan_optimizer_macos_compilation branch from 7754b27 to 725f3b7 Compare September 10, 2024 09:26
@fabian-lunarg fabian-lunarg deleted the fabian_fix_vulkan_optimizer_macos_compilation branch September 17, 2024 07:38
@fabian-lunarg fabian-lunarg restored the fabian_fix_vulkan_optimizer_macos_compilation branch September 17, 2024 07:39
@fabian-lunarg fabian-lunarg reopened this Sep 17, 2024
@bartosz-muszarski-arm bartosz-muszarski-arm merged commit dfc7788 into bartosz-muszarski-arm:vulkan-optimizer Jan 9, 2025
@fabian-lunarg fabian-lunarg deleted the fabian_fix_vulkan_optimizer_macos_compilation branch January 30, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlibanya hlibanya hlibanya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabian-lunarg @hlibanya @bartosz-muszarski-arm