[Feature] add Dockerfile for binary #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanut32039
changed the title
nkitlabs
reviewed
Jan 26, 2025
dockerfile
Outdated
Comment on lines
8
to
13
| # Add source files | ||
| COPY . . | ||
|
|
||
| # install binary | ||
| RUN go mod download | ||
| RUN make install |
There was a problem hiding this comment.
should we support on different build/target architects
There was a problem hiding this comment.
another question should we label the image?
There was a problem hiding this comment.
another question should we label the image?
Go relayer has it too. Let me add it
There was a problem hiding this comment.
should we support on different build/target architects
added
added 2 commits
January 28, 2025 10:07
nkitlabs
reviewed
Jan 28, 2025
dockerfile
Outdated
| wget -c https://musl.cc/x86_64-linux-musl-cross.tgz -O - | tar -xzvv --strip-components 1 -C /usr; \ | ||
| fi | ||
|
|
||
| ADD . . |
There was a problem hiding this comment.
this add the whole project, should we add .dockerignore file?
RogerKSI
reviewed
Jan 28, 2025
.dockerignore
Outdated
| LICENSE | ||
| logo.svg | ||
| README.md | ||
| SECURITY.md |
RogerKSI
reviewed
Jan 28, 2025
dockerfile
Outdated
| @@ -0,0 +1,35 @@ | |||
| FROM --platform=$BUILDPLATFORM golang:1.22.3-alpine3.19 as build | |||
There was a problem hiding this comment.
file name should be Dockerfile (big D)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #XXXX
Implementation details
Please ensure the following requirements are met before submitting a pull request:
CHANGELOG_UNRELEASED.mdFiles changedtab in the Github PR explorer)