Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add More Details to GetInfo #94

Merged
merged 2 commits into from
Nov 1, 2024
Merged

[feat] Add More Details to GetInfo #94

merged 2 commits into from
Nov 1, 2024

Conversation

warittornc
Copy link
Member

Implementation details

  • Do 1
  • Do 2

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the GitHub PR explorer)

Copy link
Collaborator

@RogerKSI RogerKSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix colmazia's comment. then, i'm ok.

@warittornc warittornc requested a review from colmazia November 1, 2024 08:43
@warittornc warittornc merged commit c32760b into main Nov 1, 2024
3 checks passed
@warittornc warittornc deleted the update-get-info branch November 1, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants