[feat] Add New Binance Websocket Source #11

warittornc · 2024-02-02T11:14:54Z

No description provided.

sorawit

Added some initial comments. See you put as drafts so didn't spend energy looking into the logic yet.

binance/src/lib.rs

binance/Cargo.lock

binance/.gitignore

Cargo.toml

binance/src/types.rs

RogerKSI · 2024-02-02T19:48:41Z

please fix clippy error as well.

sorawit

more comments

Cargo.toml

binance/src/websocket/websocket.rs

binance/src/websocket/util.rs

binance/src/websocket/websocket.rs

bothan-binance/src/websocket/websocket.rs

bothan-binance/src/types.rs

bothan-binance/src/cache/cache.rs

bothan-binance/src/service.rs

sorawit

add more reviews. still need to look at service.rs

bothan-binance/src/cache/cache.rs

bothan-binance/src/api/error.rs

bothan-binance/src/api/websocket.rs

bothan-binance/src/cache/dash_map.rs

bothan-binance/src/cache/types.rs

bothan-binance/src/cache/dash_map.rs

bothan-binance/src/types.rs

bothan-binance/src/service.rs

bothan-binance/Cargo.toml

bothan-binance/src/api/types.rs

bothan-binance/src/service.rs

bothan-binance/examples/dummy_example.rs

bothan-binance/src/api/websocket.rs

bothan-binance/src/service.rs

bothan-core/src/cache.rs

bothan-core/src/cache/types.rs

sorawit

Just a few more comments. Once they are all addressed, this is good to me

bothan-core/src/cache/hashmap.rs

bothan-binance/src/service.rs

init

c75f157

warittornc requested a review from RogerKSI February 2, 2024 11:14

sorawit reviewed Feb 2, 2024

View reviewed changes

binance/src/lib.rs Outdated Show resolved Hide resolved

binance/Cargo.lock Outdated Show resolved Hide resolved

binance/.gitignore Outdated Show resolved Hide resolved

Cargo.toml Outdated Show resolved Hide resolved

warittornc added 4 commits February 3, 2024 00:43

reformat

b5d1a89

minor cleanup

56a24dc

change package name

2f01e52

minor cleanup

0517535

RogerKSI reviewed Feb 2, 2024

View reviewed changes

binance/src/types.rs Outdated Show resolved Hide resolved

sorawit requested changes Feb 5, 2024

View reviewed changes

warittornc added 3 commits February 5, 2024 17:15

checkpoint

ee05365

checkpoint

8f19455

minor cleanup

bba1526

warittornc requested review from sorawit and RogerKSI February 5, 2024 10:30

warittornc added 3 commits February 5, 2024 17:43

minor cleanup

f00e402

minor change

d09a40b

organize imports

858c4b3

sorawit requested changes Feb 5, 2024

View reviewed changes

warittornc added 3 commits February 5, 2024 17:52

minor cleanup

7eaa92f

minor cleanup

21e2031

fix

d304e88

warittornc requested a review from sorawit February 6, 2024 08:26

warittornc added 2 commits February 6, 2024 15:26

fix

f6038c5

fix linting

8b41fcb

warittornc marked this pull request as ready for review February 6, 2024 08:32

sorawit requested changes Feb 6, 2024

View reviewed changes

bothan-binance/src/types.rs Outdated Show resolved Hide resolved

bothan-binance/src/service.rs Outdated Show resolved Hide resolved

warittornc added 2 commits February 6, 2024 17:34

cleanup cache

4052ff9

fix and cleanup

e3d5206

warittornc added 3 commits February 7, 2024 11:57

cleanup and fixed

c06cb9e

add panic msg

e2337e5

renamed variable for clarity and added comment

c65e6d8

warittornc requested a review from sorawit February 7, 2024 08:48

fixed clippy

6451ce1

RogerKSI reviewed Feb 11, 2024

View reviewed changes

RogerKSI requested review from taobun and nkitlabs February 11, 2024 16:41

warittornc added 5 commits February 12, 2024 11:33

fixed

156d749

change from set_pending to set_batch_pending

8473881

fixed

ef206be

remove tests

6143cbc

cleanup

4c06bdb

warittornc requested a review from RogerKSI February 12, 2024 08:42

warittornc added 4 commits February 12, 2024 15:43

fixed clippy

6ef569f

restructure out cache

bfac8e0

fix

156d330

add core

36e072b

RogerKSI reviewed Feb 13, 2024

View reviewed changes

bothan-binance/src/service.rs Outdated Show resolved Hide resolved

bothan-binance/src/service.rs Outdated Show resolved Hide resolved

changes

e423854

RogerKSI reviewed Feb 13, 2024

View reviewed changes

bothan-core/src/cache.rs Outdated Show resolved Hide resolved

bothan-core/src/cache/types.rs Outdated Show resolved Hide resolved

sorawit requested changes Feb 14, 2024

View reviewed changes

bothan-core/src/cache/hashmap.rs Show resolved Hide resolved

bothan-binance/src/service.rs Show resolved Hide resolved

change cache to generic

4fc5f11

sorawit approved these changes Feb 14, 2024

View reviewed changes

warittornc added 2 commits February 14, 2024 16:55

fix clippy

b77f62e

fix clippy

04e1a9a

warittornc requested a review from RogerKSI February 14, 2024 09:59

RogerKSI approved these changes Feb 15, 2024

View reviewed changes

warittornc merged commit 42cde97 into main Feb 15, 2024
3 checks passed

warittornc deleted the revamp branch February 15, 2024 08:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feat] Add New Binance Websocket Source #11

[feat] Add New Binance Websocket Source #11

warittornc commented Feb 2, 2024

sorawit left a comment

RogerKSI commented Feb 2, 2024

sorawit left a comment

sorawit left a comment

sorawit left a comment

[feat] Add New Binance Websocket Source #11

[feat] Add New Binance Websocket Source #11

Conversation

warittornc commented Feb 2, 2024

sorawit left a comment

Choose a reason for hiding this comment

RogerKSI commented Feb 2, 2024

sorawit left a comment

Choose a reason for hiding this comment

sorawit left a comment

Choose a reason for hiding this comment

sorawit left a comment

Choose a reason for hiding this comment