[feat] Add Key Command #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogerKSI
reviewed
Nov 23, 2024
colmazia
reviewed
Nov 27, 2024
| .with_context(|| "Failed to create monitoring key file")?; | ||
|
|
||
| file.write(signer.to_hex().as_bytes()) | ||
| .with_context(|| "Failed to write monitoring key file")?; |
There was a problem hiding this comment.
Can we make file creation and writing atomic, now if there is writing error, user will get empty file?
There was a problem hiding this comment.
switched to user input
There was a problem hiding this comment.
still see the file creation and writing na
RogerKSI
approved these changes
Nov 29, 2024
colmazia
approved these changes
Nov 29, 2024
| .with_context(|| "Failed to create monitoring key file")?; | ||
|
|
||
| file.write(signer.to_hex().as_bytes()) | ||
| .with_context(|| "Failed to write monitoring key file")?; |
There was a problem hiding this comment.
still see the file creation and writing na
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation details
Please ensure the following requirements are met before submitting a pull request:
CHANGELOG.mdFiles changedtab in the GitHub PR explorer)