Removed custom configuration URLs

bahadirbasaran · Sep 3, 2024 · 7615bd1 · 7615bd1
1 parent 22a767c
commit 7615bd1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/core/config.py b/core/config.py
@@ -16,13 +16,12 @@
 # matches all the expected output values typed by user with one of the nested
 # items in e.g. "exact" param of response. Otherwise, it returns an error
 # "<param>: No item matching all the expected inputs found!".
-#   https://stat.ripe.net/data/address-space-hierarchy/data.json?resource=110/4
 
 
 # Application-wide definitions
 BATCH_SIZE = 20
-MATTERMOST_URL = "https://mattermost.ripe.net/hooks/6xp8tt93i3fwde5d43jegsxi8a"
-SLACK_URL = "https://hooks.slack.com/services/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"
+MATTERMOST_URL = "YOUR_MATTERMOST_HOOK_URL"
+SLACK_URL = "YOUR_SLACK_HOOK_URL"
 
 ALL = "All following are True"
 ANY = "At least one of following is True"

diff --git a/scripts/okr.py b/scripts/okr.py
@@ -42,9 +42,9 @@ def post_data_to_GCS(file_path):
 
     file_name = file_path[:-4].split('/')[-1]
     bucket_name = "stat_bucket"
-    bucket_url = "https://storage.googleapis.com/stat_bucket/"
+    bucket_url = "https://storage.googleapis.com/stat_bucket/"  # This is a public bucket.
 
-    client = storage.Client.from_service_account_json(json_credentials_path="") # TODO: credentials are required to be hidden.
+    client = storage.Client.from_service_account_json(json_credentials_path="")
     bucket = storage.Bucket(client, bucket_name)
     blob = bucket.blob(file_name)
     blob.upload_from_filename(file_path)