feat(agent): binary stop returns exec bytes in HTTP response (Priority 1)#29
Open
baekchangjoon wants to merge 2 commits into
Open
feat(agent): binary stop returns exec bytes in HTTP response (Priority 1)#29baekchangjoon wants to merge 2 commits into
baekchangjoon wants to merge 2 commits into
Conversation
Eliminate file-poll races by serializing JaCoCo exec data in the HTTP response body when format=binary. Legacy text stop and disk persist remain backward compatible via persistOnStop and format=text defaults. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
CI publishes 1.4.0 to mavenLocal; gradle-sample and maven-plugin still referenced 1.3.0, causing plugin resolution and agent dependency failures. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
format=binarytoPOST /__coverage__/test/stopto return JaCoCo.execbytes in the response body (application/octet-stream), eliminating file-poll races under load.ExecWriterinto in-memory serialization (toExecBytes) and separate disk writers.TestStoreRegistryclose vs persist (closeForStop/persistClosed); legacyformat=textstop unchanged.persistOnStopagent option (defaulttrue).Version
v1.4.0withpjacoco-agent-1.4.0.jarbefore merging the companion graph-rag-builder PR.Test plan
./gradlew :agent:test(all unit tests green)ControlEndpointStopBinaryTest— legacy text, binary 200/204/404ExecSerializerTest— round-trip matches file writerRelated
Made with Cursor