Design change separate filters api call #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter_centers, updated tests isolated from api calls
|
This is being covered in #17, closing the pull request. |
… lists, moved from constants to utils, make filters pythonic, add one test
|
reopening for comparison |
This was referenced May 18, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…updated tests isolated from api calls
all tests passed, except the first two
test_get_statesandtest_get_districts. I manually tried to run the urls in the browser and get the similar{"message":"Forbidden"}error.Please have a look at the function
filter_centers. I might have made it a little difficult to understand and welcome your comments/suggestions to improve the same.Now the filters available are
min_age_limit,min_capacity,vaccine, andfee_type.