Skip to content

Remove unused symlink code - #37

Merged
bachand merged 7 commits into
masterfrom
mb--rework-entry-point
Oct 12, 2025
Merged

Remove unused symlink code#37
bachand merged 7 commits into
masterfrom
mb--rework-entry-point

Conversation

@bachand

@bachand bachand commented Oct 11, 2025

Copy link
Copy Markdown
Owner

In working on #32 I realized that there's unused symlink Ruby code. I'm going to remove this code since it's always possible to restore it from the git history if necessary.

I ran ./bin/battlestation setup locally. I removed the symlink to my .zshrc file and verified that the symlink was created by the setup script.

@bachand
bachand requested a review from Copilot October 12, 2025 00:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes unused symlink functionality from the Battlestation project. The symlink feature appears to have been partially implemented but never completed or utilized.

  • Removes the incomplete Battlestation::Symlink class and its test file
  • Deletes the unused symlinks configuration file
  • Updates GitHub Actions workflow to use newer action versions and bundler cache

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
spec/battlestation/symlink_spec.rb Removes incomplete test file for symlink functionality
lib/battlestation/symlink.rb Removes the incomplete Symlink class with unimplemented methods
lib/battlestation.rb Removes the require statement for the deleted symlink module
config/symlinks.yaml Removes configuration file that defined symlink mappings
.github/workflows/ruby.yml Updates GitHub Actions to use newer checkout versions and bundler cache

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@bachand
bachand marked this pull request as ready for review October 12, 2025 00:02
branches: [ master ]

jobs:
test-linux:

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tool is only meant to support macOS.

Comment thread lib/battlestation/cli.rb
Output.put_success("Setup completed.")
Output.put_info("Please close and reopen your shell.")

return $?.exitstatus

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were previously returning the exit status from the last time we called into the shell without considering the previous shell invocations. I think it's preferable to avoid returning an exit status until orunless we can return one that's more meaningful.

@bachand
bachand merged commit d4fd372 into master Oct 12, 2025
1 check passed
@bachand
bachand deleted the mb--rework-entry-point branch October 12, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants