Remove unused symlink code - #37
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes unused symlink functionality from the Battlestation project. The symlink feature appears to have been partially implemented but never completed or utilized.
- Removes the incomplete
Battlestation::Symlinkclass and its test file - Deletes the unused symlinks configuration file
- Updates GitHub Actions workflow to use newer action versions and bundler cache
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| spec/battlestation/symlink_spec.rb | Removes incomplete test file for symlink functionality |
| lib/battlestation/symlink.rb | Removes the incomplete Symlink class with unimplemented methods |
| lib/battlestation.rb | Removes the require statement for the deleted symlink module |
| config/symlinks.yaml | Removes configuration file that defined symlink mappings |
| .github/workflows/ruby.yml | Updates GitHub Actions to use newer checkout versions and bundler cache |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| branches: [ master ] | ||
|
|
||
| jobs: | ||
| test-linux: |
There was a problem hiding this comment.
This tool is only meant to support macOS.
| Output.put_success("Setup completed.") | ||
| Output.put_info("Please close and reopen your shell.") | ||
|
|
||
| return $?.exitstatus |
There was a problem hiding this comment.
We were previously returning the exit status from the last time we called into the shell without considering the previous shell invocations. I think it's preferable to avoid returning an exit status until orunless we can return one that's more meaningful.
In working on #32 I realized that there's unused symlink Ruby code. I'm going to remove this code since it's always possible to restore it from the git history if necessary.
I ran
./bin/battlestation setuplocally. I removed the symlink to my .zshrc file and verified that the symlink was created by the setup script.