SO-6308 FULL import remote job fetch issues #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 9.x #1344 +/- ##
============================================
+ Coverage 63.67% 63.69% +0.01%
- Complexity 12523 12534 +11
============================================
Files 1612 1613 +1
Lines 57120 57215 +95
Branches 5622 5629 +7
============================================
+ Hits 36373 36444 +71
- Misses 18397 18418 +21
- Partials 2350 2353 +3 ☔ View full report in Codecov by Sentry. |
cmark
requested changes
Nov 25, 2024
There was a problem hiding this comment.
I reviewed the 7.x variant first, see my comments there:
#1345 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7.x version in #1345