-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(index): Revise merged revisions to avoid duplication #1170
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 9.x #1170 +/- ##
============================================
- Coverage 64.09% 64.08% -0.01%
Complexity 13169 13169
============================================
Files 1796 1796
Lines 61540 61540
Branches 5717 5717
============================================
- Hits 39441 39440 -1
- Misses 19621 19623 +2
+ Partials 2478 2477 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥓 Looks okay, but let me check a few things before merging.
Migrating to 9.x |
...and target for "net zero" changes; don't mention the object in the corresponding commit document however.
54719ba
to
a5979c1
Compare
NOTE: test cases have been moved to https://github.com/b2ihealthcare/snow-owl-ext/pull/2739 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM!
This PR adds two test cases and a proposed fix to the issue where two revisions on separate branches end up in the same state, but neither receives a
revised
entry when one of the branches is merged to the other. Subject to further discussions. 😄Related ticket: https://snowowl.atlassian.net/browse/SO-5672