Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch github-ci #8

Closed
wants to merge 9 commits into from
Closed

patch github-ci #8

wants to merge 9 commits into from

Conversation

dudong2
Copy link
Collaborator

@dudong2 dudong2 commented Jul 5, 2024

Closes: #XXX

Description

NOTE

  • Currently, the GitHub CI workflow being used is the one from the archived project evmos/ethermint.
  • I'm planning to adopt the CI workflow from cronos or cosmos-sdk.
  • Until this work is implemented, do not review is pr

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@dudong2 dudong2 self-assigned this Jul 5, 2024
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@dudong2 dudong2 requested review from dongsam, zsystm and poorphd and removed request for dongsam and zsystm July 9, 2024 14:50
@dudong2 dudong2 removed the request for review from poorphd July 10, 2024 04:27
@dudong2 dudong2 closed this Jul 19, 2024
@dudong2 dudong2 deleted the patch/ci branch July 19, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants