Summer Package refresh 2020#50
Merged
AdrieanKhisbe merged 4 commits intoazeemba:masterfrom Jul 22, 2020
Merged
Conversation
azeemba
reviewed
Jul 20, 2020
Owner
azeemba
left a comment
azeemba
left a comment
There was a problem hiding this comment.
Looks like mocha doesn't support Node8.
Should we remove Node8 from the tests? Or should we stick with the older mocha?
Collaborator
Author
|
@azeemba Ooops, little oversight from my side. I think we should land this refresh with node 8 support, but then on the long term I'm not sure yet we should drop node8 on short notice:
(then would come question if we should drop 🎱 before addressing #39 and #37) |
AdrieanKhisbe
force-pushed
the
package-refresh-2020-summer
branch
from
5a54f47 to
aa5c9ba
Compare
Collaborator
Author
|
(rebased to downgrade |
azeemba
approved these changes
Jul 21, 2020
Owner
azeemba
left a comment
azeemba
left a comment
There was a problem hiding this comment.
Thanks for the update!
Once this is merged, I will push out a release.
Collaborator
Author
|
Et voilà :) IMO, considering changes, a patch would do. ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch of package updates
Replace #47, #48, #49 and #51