Integration test against several eslint majors#46
Merged
AdrieanKhisbe merged 2 commits intoazeemba:masterfrom May 20, 2020
Merged
Conversation
azeemba
approved these changes
May 16, 2020
AdrieanKhisbe
force-pushed
the
integration-test-against-several-eslint-majors
branch
from
d897df4 to
ac1f44e
Compare
Collaborator
Author
|
(I just rebased to fix conflict induced by #41 :)) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves tests and CI to ensure plugin working for different eslint major ranges. (mentionned in #43 (comment))
So far, eslint v6 is supported for all supported node ranges (8 to 14 (14 introduced in this PR)).
and eslint v7 supported started from node 10. (which is an eslint v7 prerequesite)
Took the opportunity to split the build into several jobs.
Ps: Some work might be necessary to see support status of v5, but as more complicated than expected, and far less important, I let it aside for the time being.