Implement Electron standalone desktop experience#924
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…ence - Added Electron main and preload scripts with native menu bar and device mounting. - Implemented host filesystem integration via ZenFS WebAccess and electron-store. - Configured conditional Vite base path (ELECTRON_BUILD toggle). - Added webRequest redirection in Electron to support hardcoded /win98-web/ paths. - Enforced trailing slashes in index.html for reliable relative path resolution on web. - Restored robust profile detection and routing in os-init.js and 404.html. - Fixed Paint application assets and double-slash path redundancies. - Corrected dependency versions in package.json. Co-Authored-By: azayrahmad <10110227+azayrahmad@users.noreply.github.com>
azayrahmad
force-pushed
the
electron-integration-6904042594588918351
branch
from
65889b5 to
1f8e96d
Compare
- Fixed "SyntaxError: The requested module 'electron' does not provide an export named 'webUtils'" by using default import for electron in main.js. - Robustly fixed 404s for hardcoded paths and iframes in Electron by updating the webRequest redirection to map /win98-web/ paths to local files or the dev server. - Restored dynamic base URL handling in Paint application. - Ensured ELECTRON_BUILD environment variable is correctly passed in scripts. Co-authored-by: azayrahmad <10110227+azayrahmad@users.noreply.github.com>
- Fixed TypeError in main.js by using createRequire for Electron modules. - Improved C: drive mounting robustness with timeouts and descriptive error messages. - Fixed potential memory leaks in preload.js by using ipcRenderer.once for handle requests. - Added version and diagnostic logging to main process. - Ensured absolute path redirection is robust across different host environments. Co-authored-by: azayrahmad <10110227+azayrahmad@users.noreply.github.com>
1 participant
This change integrates Electron into the Windows 98 Web Edition project, allowing it to be run as a standalone desktop application. It features real host filesystem access for the C: drive and removable disks, native Windows menus for system actions and device mounting, and a persistent configuration for the user's selected system folder. The web version remains fully compatible through dynamic environment detection and relative path handling.
PR created automatically by Jules for task 6904042594588918351 started by @azayrahmad