Build improvements #125
Merged
Build improvements #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use action to install rust toolchain which also does some workarounds / enables color. Dont use old unmaintained action-rs actions, use in manually. Downside: warnings get lost → deny everything and get a hard error. With ring 0.17 out test platforms like risc-v or arm64 on windows.
When this is forgotten locally only the CI will notice this. Now these lints are always performed with clippy. Also cleanup the list of allowed lints and add future ones from the nursery which could also already be implemented.
ayrat555
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of changes not directly related to the code…