Add .clang-format file; fix ldt test for x64; remove an unused local variable#292
Merged
ayoubfaouzi merged 1 commit intoayoubfaouzi:masterfrom Jul 14, 2025
Conversation
Owner
|
Hey @IgorKorkin Thanks for adding that clang-format 👍 , I will later add like a pre-commit-hook or a test in CI to force contributors to format the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.clang-format, as we discussed early fix build warnings and apply code style #291 (comment).gitignoreget_ldt_base()for x64SLDT instruction fails if
If CR4.UMIP = 1 and CPL > 0., see https://www.felixcloutier.com/x86/sldtwhere
UMIP- User-Mode Instruction Prevention (if set, #GP on SGDT, SIDT, SLDT, SMSW, and STR instructions when CPL > 0)lack_user_input()