Skip to content

fix bugs generated by _steps null in discoverFeatures and _alreadyCompletedSteps methods #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frsisalima wants to merge 11 commits into
base: master
Choose a base branch
from
+5 −6
Open

fix bugs generated by _steps null in discoverFeatures and _alreadyCompletedSteps methods #42

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
424588e
fix bug caused by _steps null in method _alreadyCompletedSteps
Sep 23, 2020
919bdcb
update version
Sep 23, 2020
21f11e9
fix bug caused by _steps null in method _alreadyCompletedSteps
Sep 23, 2020
e59b034
Merge branch 'master' of https://github.com/frsisalima/feature_discovery
Sep 23, 2020
6d881ef
fix bug caused by _steps null in method _alreadyCompletedSteps
Sep 23, 2020
633b8ab
fix bug caused by _steps null in method _alreadyCompletedSteps
Sep 23, 2020
ad2b7f6
Merge branch 'master' into master
frsisalima Oct 8, 2020
f6fb3cb
format code
Nov 30, 2020
2493309
fix format
Dec 1, 2020
9255472
fix format
Dec 1, 2020
93fe1a6
fix format
Dec 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/src/foundation/bloc.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ class Bloc {

_steps = steps;
_stepsToIgnore = await _alreadyCompletedSteps;
_steps = _steps.where((s) => !_stepsToIgnore.contains(s)).toList();
_steps = _steps!=null?_steps.where((s) => !_stepsToIgnore.contains(s)).toList():[];

@noordawod noordawod Nov 30, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's your problem with spacing? :)

@frsisalima frsisalima Nov 30, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what is the problem, the log error is:

lib/src/foundation/bloc.dart
lib/src/rendering/custom_layout.dart
test/feature_discovery_test.dart
Formatting failed: 1
Error: Process completed with exit code 1.

_activeStepIndex = -1;

await _nextStep();
Expand Down Expand Up @@ -156,9 +156,9 @@ class Bloc {
Future<Set<String>> get _alreadyCompletedSteps async {
if (!recordInSharedPrefs) return {};
final prefs = await SharedPreferences.getInstance();
return _steps
return _steps!=null?_steps
.where((s) => prefs.getBool('$sharedPrefsPrefix$s') == true)
.toSet();
.toSet():{};
}

/// Returns true iff this step has been previously
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: >-
A Flutter package that implements Material Design Feature discovery
to show a description of specific features to new users.
See https://tinyurl.com/FeatureDiscovery
version: 0.12.0+2
version: 0.12.1+3
homepage: https://github.com/ayalma/feature_discovery

environment:
Expand Down