[Android] FileUtils::listFiles implementation that works with empty folders #2463
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This is an attempt to fix the issue of empty folder names missing from
FileUtils::listFiles()
on Android when the path is in the assets folder (within the APK).This now uses the Java implementation of
AssetManager.list()
, which does return all file and folder names. This will then useAssetManager.open()
to check if the path is a file or folder, but if anyone knows of a better way to handle this, then please state what it is.Files in the
assets
folder will be relative to that folder, and the "assets/" prefix will not be added to them, since it is not required.Issue ticket number and link
#2458
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."
I have performed a self-review of my code.
Optional:
For core/new feature PR