p2psim: Enhance p2psim for DHT benchmarks #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonhv0212
force-pushed
the
feat/dht-bucket-size
branch
8 times, most recently
from
ab39089 to
dc2410b
Compare
sonhv0212
force-pushed
the
feat/dht-bucket-size
branch
3 times, most recently
from
7ad48b5 to
3976246
Compare
sonhv0212
changed the title
sonhv0212
force-pushed
the
feat/dht-bucket-size
branch
from
3976246 to
e10a78d
Compare
sonhv0212
changed the title
This commit enhances the p2p simulation server to facilitate benchmarking of the discovery process in DHT. Key updates include: - Exposing APIs for improved control and observability during simulation. - Adding configurable parameters for simulation nodes (inproc) to support benchmarking scenarios. - Implementing a new benchmark strategy to measure the impact of applying ENR filtering and increasing the DHT bucket size.
sonhv0212
force-pushed
the
feat/dht-bucket-size
branch
from
e10a78d to
f22279e
Compare
|
@sonhv0212 Could u update how to run inside examples folder as same with ping-pong service examples ? or I think u can move discovery folder inside examples too, and move ping-pong to subfolder call ping-pong ? |
I moved ping-pong and discovery to the examples folder |
|
|
||
| "github.com/ethereum/go-ethereum/core/forkid" | ||
| "github.com/ethereum/go-ethereum/event" |
There was a problem hiding this comment.
please update inproc_test for adapting the new changes.
sonhv0212
force-pushed
the
feat/dht-bucket-size
branch
from
86ba22f to
455e285
Compare
sonhv0212
force-pushed
the
feat/dht-bucket-size
branch
from
fb68f6f to
32a59ce
Compare
|
Seem good for me. |
chiphamskymavis
approved these changes
Dec 26, 2024
huyngopt1994
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances the p2p simulation server to facilitate benchmarking of the discovery process in DHT. Key updates include: