Set S3AsyncClient endpoint from localstack if available in tests #1330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Changing
S3CrtAsyncClientAutoConfiguration#s3AsyncClient
to callAwsConnectionDetails#getEndpoint
if available that should provide theS3AsyncClient
with the endpoint to the localstack container if available.I'm not sure if this was the right way to achieve this, hence a draft PR
💡 Motivation and Context
Fixes #1329. It looks like the
S3AsyncClient
wasn't fetching the endpoint from localstack container💚 How did you test it?
Added a test method
AwsContainerConnectionDetailsFactoryTest#configuresS3AsyncClientWithServiceConnection
that checks@Autowired S3AsyncClient client
can list buckets while relying in@ServiceConnection
localstack container📝 Checklist
🔮 Next steps
None?