Spring modulith 1.3 upgrade #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test for header addition are incomplete!
To benefit from the Support for SpEL expressions using the event when calculating the routing target. See spring-projects/spring-modulith#881 for details.
odrotbohm
requested review from
maciejwalkowiak,
MatejNedic and
tomazfernandes
as code owners
maciejwalkowiak
added
component: sns
github-actions
bot
removed
component: sns
maciejwalkowiak
approved these changes
Jan 16, 2025
MatejNedic
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
As discussed with Maciej, this PR contains the upgrade to Spring Modulith 1.3.1 plus adaptions to now also include automatic header addition based on the externalization configuration. The tests for the header additiona are incomplete as I didn't get them to work and don't understand why.
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps