Conversation
Collaborator
|
Thank you @fabianfett for this patch. I take the responsibility of the original error :-) I just tested it with the APIGateway example (as per "Steps to reproduce" in the issue description). I confirm this fixes the error. Can you delete from this PR the On a side not, the CI fails to compile |
sebsto
reviewed
Mar 1, 2025
Collaborator
sebsto
left a comment
sebsto
left a comment
There was a problem hiding this comment.
With the exception of the example code, LGTM
Package.swift
Outdated
| .byName(name: "AWSLambdaTesting") | ||
| ] | ||
| ), | ||
| .executableTarget( |
Collaborator
There was a problem hiding this comment.
I think this was for your own test. I think we can remove this
Sources/HelloWorldLambda/main.swift
Outdated
| @@ -0,0 +1,29 @@ | |||
| //===----------------------------------------------------------------------===// | |||
Collaborator
There was a problem hiding this comment.
This file can be remove for the PR too,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #488