Skip to content

Enable Swift 6 mode! #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 20, 2025
Merged

Enable Swift 6 mode! #482

merged 3 commits into from
Feb 20, 2025

Conversation

@fabianfett
Copy link
Contributor

@fabianfett fabianfett commented Feb 20, 2025

This is a huge step into being 100% sendable safe in Lambda!

@fabianfett fabianfett added the ⚠️ semver/major Breaks existing public API. label Feb 20, 2025
@fabianfett
Copy link
Contributor Author

fabianfett commented Feb 20, 2025 

1 breaking change detected in AWSLambdaRuntime:
  💔 API breakage: constructor LambdaCodableAdapter.init(encoder:decoder:handler:) has parameter 2 changing from Default to Owned

9 breaking changes detected in AWSLambdaRuntimeCore:
  💔 API breakage: constructor LambdaHandlerAdapter.init(handler:) has parameter 0 changing from Default to Owned
  💔 API breakage: constructor LambdaCodableAdapter.init(encoder:decoder:handler:) has parameter 0 changing from Default to Owned
  💔 API breakage: constructor LambdaCodableAdapter.init(encoder:decoder:handler:) has parameter 1 changing from Default to Owned
  💔 API breakage: constructor LambdaCodableAdapter.init(encoder:decoder:handler:) has parameter 2 changing from Default to Owned
  💔 API breakage: constructor LambdaCodableAdapter.init(decoder:handler:) has parameter 0 changing from Default to Owned
  💔 API breakage: constructor ClosureHandler.init(body:) has parameter 0 changing from Default to Owned
  💔 API breakage: constructor LambdaRuntime.init(encoder:decoder:body:) has parameter 0 changing from Default to Owned
  💔 API breakage: constructor LambdaRuntime.init(encoder:decoder:body:) has parameter 1 changing from Default to Owned
  💔 API breakage: constructor LambdaRuntime.init(decoder:body:) has parameter 0 changing from Default to Owned

Expected! We are fine with this!

@sebsto
Copy link
Collaborator

sebsto commented Feb 20, 2025

LGTM - the examples code doesn't even break

@fabianfett fabianfett merged commit d778048 into awslabs:main Feb 20, 2025
30 of 31 checks passed
@fabianfett fabianfett deleted the ff-swift-6 branch February 20, 2025 15:20
@sebsto sebsto mentioned this pull request Feb 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebsto sebsto sebsto approved these changes

+1 more reviewer

@FranzBusch FranzBusch FranzBusch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

⚠️ semver/major Breaks existing public API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fabianfett @sebsto @FranzBusch