Skip to content

Conversation

@CarlosCuevas
Copy link
Contributor

Fix inaccurate comments in getGroupOperations function

Purpose

This pull request addresses inaccurate comments in the getGroupOperations function. The existing comments do not correctly describe the function's behavior, which could lead to misunderstandings and potential bugs in future development.

Changes

  • Corrected internal comments to properly reflect the operations being performed

@ChrisPates ChrisPates added this to the v2.3 milestone Oct 23, 2025
@ChrisPates ChrisPates self-assigned this Oct 23, 2025
@ChrisPates ChrisPates self-requested a review October 23, 2025 15:05
@ChrisPates ChrisPates added documentation Improvements or additions to documentation go Pull requests that update go code labels Oct 23, 2025
Copy link
Contributor

@ChrisPates ChrisPates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contributor is indeed correct the comments are logically inverted compare with the code.

@ChrisPates ChrisPates merged commit 243f7b9 into awslabs:master Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation go Pull requests that update go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants