Skip to content

Conversation

@devinglauner
Copy link
Contributor

@devinglauner devinglauner commented Oct 22, 2025

Issue #, if available: n/a

Notes

Updated sample model output data and test files to align with the current guidance for model return values. This change standardizes the output format across sample data files and ensures test consistency.

Changes

  • Updated source code for aircraft, centerpoint, and flood models to use standardized output format:
    • Changed from bounds_imcoords to imageBBox property naming
    • Replaced feature_types object with featureClasses array containing IRI and score
    • Updated geometry structure to use null instead of Point coordinates
    • Added modelMetadata with model name, ontology name, and version
    • Updated property structure for mask handling (geom_imcoordsimageGeometry)
  • Updated test files to match the model return changes
  • Updated copyright year from 2024 to 2025
  • Regenerated sample output data to reflect the new standardized format

Impact

  • Ensures test models return values consistent with current model output guidance
  • Standardizes property naming conventions across sample data

Files Modified

  • src/aws/osml/models/aircraft/app.py
  • src/aws/osml/models/server_utils.py
  • test/aws/osml/models/flood/test_flood_model.py
  • test/sample_data/sample_centerpoint_model_output.geojson
  • test/sample_data/sample_flood_model_output.geojson

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@drduhe drduhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@drduhe drduhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devinglauner devinglauner merged commit d21ddda into main Oct 24, 2025
5 checks passed
@devinglauner devinglauner deleted the fix/update-test-models branch October 24, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants