-
Notifications
You must be signed in to change notification settings - Fork 1
feat: implement ship model endpoint #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f4ca080 to
8055a38
Compare
Coverage report
Show files with reduced coverage 🔻
Test suite run success42 tests passing in 16 suites. Report generated by 🧪jest coverage report action from c7979c1 |
| } | ||
|
|
||
| if (this.config.DEPLOY_SM_SHIP_ENDPOINT) { | ||
| this.aircraftModelEndpoint = new MESMEndpoint( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
concern: Looks like cut and paste errors here. Do you really want to overwrite this.aircraftModelEndpoint with the ship model endpoint or should that be a new attribute?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was an error and it's already fixed in my dev branch where I am testing stuff.
| DEPLOY_SM_AIRCRAFT_ENDPOINT: true, | ||
| DEPLOY_SM_CENTERPOINT_ENDPOINT: true, | ||
| DEPLOY_SM_FLOOD_ENDPOINT: true, | ||
| DEPLOY_SM_SHIP_ENDPOINT: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
concern: It seems like the if-check on line #358 (new) #344 (old) needs to be updated to consider this flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an update to this PR coming - it's still a WIP - updated overview to state such. I.E. why I didn't check any of the boxes in the PR overview yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: It looks to me like the issues noted would make this not work at all. Were these changes tested?
8055a38 to
c7979c1
Compare
WIP
Issue #, if available: n/a
Notes
Implement ship model endpoint for change: awslabs/osml-models#57
Changes
METestEndpointsConfigDEPLOY_SM_SHIP_ENDPOINTflag (defaults tofalse)SM_SHIP_MODELconfiguration (defaults to "ship")METestEndpointsclassKey Details
MODEL_SELECTIONenvironment variable set to "ship"DEPLOY_SM_SHIP_ENDPOINT: false)Files Modified
lib/osml/model_endpoint/me_test_endpoints.ts(+68 lines)The implementation follows the same pattern as existing model endpoints (aircraft, centerpoint, flood) but is specifically configured for ship detection models.
Checklist
Before you submit a pull request, please make sure you have the following:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.