fix: always use constant time comparisons for tag values #320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Since
confirmation_tag
andmembership_tag
are MAC values, we should use constant time comparisons for them in all cases. This behavior is covered everywhere by custom implementing PartialEq with the subtle crate'sct_eq
functionTesting:
Covered by existing tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.