Skip to content

Conversation

tomleavy
Copy link
Contributor

@tomleavy tomleavy commented Oct 1, 2025

Description of changes:

The pretty_bytes function allows for a user to specify raw byte output, which a user can accidentally use to log secret values. This PR removes the pretty_bytes function from structs or fields that contain secrets

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

@tomleavy tomleavy requested a review from a team as a code owner October 1, 2025 19:25
@tomleavy tomleavy force-pushed the debug-improvements branch from 66f98d0 to 65aedea Compare October 1, 2025 19:26
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.68%. Comparing base (0e602b4) to head (65aedea).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
mls-rs-crypto-traits/src/kem.rs 0.00% 4 Missing ⚠️
mls-rs-core/src/crypto.rs 0.00% 3 Missing ⚠️
mls-rs/src/client_builder.rs 0.00% 3 Missing ⚠️
mls-rs/src/group/key_schedule.rs 0.00% 3 Missing ⚠️
mls-rs-core/src/group/group_state.rs 0.00% 1 Missing ⚠️
mls-rs-core/src/psk.rs 0.00% 1 Missing ⚠️
mls-rs-core/src/secret.rs 0.00% 1 Missing ⚠️
.../src/group/ciphertext_processor/sender_data_key.rs 0.00% 1 Missing ⚠️
mls-rs/src/group/epoch.rs 0.00% 1 Missing ⚠️
mls-rs/src/group/proposal.rs 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #318      +/-   ##
==========================================
+ Coverage   88.50%   88.68%   +0.17%     
==========================================
  Files         182      182              
  Lines       29002    28944      -58     
==========================================
  Hits        25668    25668              
+ Misses       3334     3276      -58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tomleavy tomleavy merged commit da545bc into main Oct 3, 2025
32 checks passed
@tomleavy tomleavy deleted the debug-improvements branch October 3, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants