Skip to content

Conversation

mulmarta
Copy link
Contributor

In general, there is no reason why a storage can't support multiple members in a single group. The new group state identifier is therefore (group_id, leaf_index) instead of just group_id.

Group states stored in the old way can be recovered using load_group(group_id).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

@mulmarta mulmarta requested a review from a team as a code owner March 19, 2024 13:36
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

❌ Patch coverage is 99.21875% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.38%. Comparing base (5235fc8) to head (fd7d8b2).
⚠️ Report is 135 commits behind head on main.

Files with missing lines Patch % Lines
mls-rs/src/group/state_repo.rs 98.41% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   89.34%   89.38%   +0.03%     
==========================================
  Files         173      173              
  Lines       31375    31454      +79     
==========================================
+ Hits        28032    28114      +82     
+ Misses       3343     3340       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mulmarta mulmarta marked this pull request as draft March 19, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants