Repository navigation
fix(aws-healthomics-mcp-server): compute returnedCount from known result-list keys - #4852
mangeshraut712 wants to merge 6 commits into
Conversation
|
Fixes #4669 Why: What: Replace positional first-list scanning with a documented allowlist of known HealthOmics result-list keys ( Test: Added regression: metadata list precedes |
|
Green and ready — happy to adjust anything. |
|
@markjschreiber @WIIASD @a-li @alxawan @MaisiLi CI is green and the contributor statement check is passing. It computes |
|
CI is green. Computes returnedCount from known result-list keys. Please review and merge when you can. |
90eae06 to
6d4b582
Compare
Fixes #4669
Summary
Changes
The pagination wrapper set
returnedCountfrom the first list-valued field in the response, in insertion order.SearchGenomicsFilesalso returnsstorage_systems_searched, a list of metadata, so when that key came first the count reported the number of storage systems instead of the number of results.returnedCountis now taken from a fixed set of known result-list keys (results,workflows,runs,readSets, and the others the paginated tools in this server return). Responses without one of those keys still report 0, as before.User experience
Before: a search page with 3 results could report
returnedCount: 2because it counted['s3', 'efs']. After: it reports 3.Checklist
Tests: added a regression test with a search response whose metadata list comes before
results.uv run --frozen pytest tests/test_pagination_hints.pypasses (16 tests).Is this a breaking change? (Y/N) N
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.