Repository navigation
fix(aws-api-mcp-server): hide call_aws when AUTH_TYPE=no-auth - #4848
Open
mangeshraut712 wants to merge 6 commits into
Open
mangeshraut712 wants to merge 6 commits into
mangeshraut712 wants to merge 6 commits into
Conversation
mangeshraut712
requested review from
a team,
PCManticore,
arnewouters,
bidesh,
iddv and
rshevchuk-git
as code owners
October 25, 2026 21:37
Contributor
Author
|
Fixes #4812 Why: With What: Omit Test: |
Contributor
Author
|
CI is green. Hides call_aws when AUTH_TYPE=no-auth. Please review and merge when you can. |
mangeshraut712
force-pushed
the
fix/no-auth-hide-call-aws
branch
from
October 27, 2026 14:47
deb11ab to
faf87c8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4812
Summary
Changes
With
AUTH_TYPE=no-authon streamable HTTP,call_awswas still registered, so anyone who could reach the endpoint could run AWS operations with the server's credentials. This leavescall_awsout of tool registration whenever the HTTP server has no authentication provider. stdio and OAuth-protected HTTP still expose it.suggest_aws_commandsandget_execution_planstay available, since they don't touch the AWS account.User experience
Before: an unauthenticated HTTP deployment exposed
call_aws. After: that deployment only lists the read-only tools; stdio and OAuth setups see no change.Checklist
Tests: regression tests reload the server under
AUTH_TYPE=no-authand under OAuth and check thatcall_awsis hidden and exposed respectively.pytest tests/test_server.py(75 passed),ruff check,ruff format --check, andpyrightare clean.Is this a breaking change? (Y/N) Y for anyone running no-auth HTTP who relied on
call_aws. That setup was unsafe, but I'm happy to add a warning or an explicit opt-in flag if you'd prefer.Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.