fix(cloudwatch-appsignals-mcp-server): update get_service_detail tool… #1504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Summary
Adding environment and service type as explicit parameters to
get_service_details
tool so the LLM can disambiguate in cases where the same service is deployed in multiple different environments within the same AWS account.Previously,
get_service_details
only required service name. This service name would then be searched in the response of a list_services boto3 call within the same tool. By explicitly providing all three parameters, we can remove this intermediate step.ref: https://boto3.amazonaws.com/v1/documentation/api/1.35.43/reference/services/application-signals/client/get_service.html
Changes
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change? (N)
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.