Skip to content

Conversation

yiyuan-he
Copy link
Contributor

@yiyuan-he yiyuan-he commented Oct 10, 2025

Fixes

Summary

Adding environment and service type as explicit parameters to get_service_details tool so the LLM can disambiguate in cases where the same service is deployed in multiple different environments within the same AWS account.

Previously, get_service_details only required service name. This service name would then be searched in the response of a list_services boto3 call within the same tool. By explicitly providing all three parameters, we can remove this intermediate step.

ref: https://boto3.amazonaws.com/v1/documentation/api/1.35.43/reference/services/application-signals/client/get_service.html

Changes

Added environment and service type as explicit parameters

Removed list_services boto3 calls calls since are no longer needed

User experience

There is no change in the user experience as the LLM can still retrieve the necessary parameters via the list_monitored_services tool.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have reviewed the contributing guidelines
  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Is this a breaking change? (N)

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

Copy link

codecov bot commented Oct 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.21%. Comparing base (9848175) to head (aaedf01).
⚠️ Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1504      +/-   ##
==========================================
- Coverage   89.39%   89.21%   -0.19%     
==========================================
  Files         722      654      -68     
  Lines       50414    45867    -4547     
  Branches     7967     7412     -555     
==========================================
- Hits        45069    40918    -4151     
+ Misses       3452     3199     -253     
+ Partials     1893     1750     -143     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@scottschreckengaust scottschreckengaust added the waiting-for-codeowners Code owners are needed to review label Oct 11, 2025
@scottschreckengaust scottschreckengaust moved this from To triage to In progress in awslabs/mcp Project Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-codeowners Code owners are needed to review

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

2 participants