Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unnecessary vec! from create_temporary_table_with_items #266

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

kzym-w
Copy link
Contributor

@kzym-w kzym-w commented Nov 25, 2024

Issue #, if available:
#238

Description of changes:
This PR addresses the issue raised in #238 by removing the unnecessary use of vec! macro when calling create_temporary_table_with_items.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kzym-w kzym-w requested a review from a team as a code owner November 25, 2024 07:33
Copy link
Contributor

@StoneDot StoneDot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@StoneDot StoneDot merged commit ffe77c1 into awslabs:main Nov 28, 2024
5 checks passed
@kzym-w kzym-w deleted the remove-unnecessary-vec branch November 29, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants